Fix bugs #695
Open
Fix bugs #695
+1,249
−961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fields are skipped
- keep content widget size isn't smaller than its viewport - scroll and clip based on the actual view size (excluding padding).
Because if `FatObj` has a class, it may convert the host into a subtree. Ensure that `FatObj` always remains on the outside to fix it.
github-actions
bot
force-pushed
the
refactor/tabs
branch
from
1744078 to
e87cb7f
Compare
github-actions
bot
force-pushed
the
refactor/tabs
branch
from
e6fdcdf to
a93c64d
Compare
github-actions
bot
force-pushed
the
refactor/tabs
branch
from
e6fdcdf to
f397c65
Compare
M-Adoo
added
B-test
wjian23
reviewed
Jan 26, 2025
| host.paint(ctx); | ||
| } | ||
|
|
||
| fn get_transform(&self, host: &dyn Render) -> Option<Transform> { |
There was a problem hiding this comment.
The transform now is used to map to parent, it seems have some bug to get_transform with wrap render which adjust some part of the host but not the entire. Here the padding wrap render will offset the host by the top, left padding, but if the position is in the padding space, it will also be offset by the top left padding, which will be map to Inaccurate position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this Pull Request
Fix some bugs described in their commits.
Checklist Before Merging
Please ensure the following are completed before merging:
CHANGELOG.mdfile.Breakingsection of theCHANGELOG.mdfile.Additional Information
The bot will replace
#prinCHANGELOG.mdwith your pull request number. If your branch is out of sync, usegit pull --rebaseto update it.If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.
If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.