Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional sudo use in scripts (and README consistency) #362

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tyler-yankee
Copy link
Collaborator

@tyler-yankee tyler-yankee commented Jan 23, 2025

This addresses #359, and serves as a follow-up to #357.


This change is Reviewable

@tyler-yankee
Copy link
Collaborator Author

The one file that isn't converted to the new system here is drake_cmake_installed/setup/install_prereqs, because that script has conflicting/conditional logic of whether or not to use sudo based on the OS.

@tyler-yankee
Copy link
Collaborator Author

+@BetsyMcPhail for feature review, please

Copy link
Contributor

@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Linux portion of drake_cmake_installed/setup/install_prereqs, the same maybe_sudo logic should be applied.

Reviewed 17 of 18 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee betsymcphail, platform LGTM missing (waiting on @tyler-yankee)


drake_bazel_external/.github/setup line 6 at r1 (raw file):

set -euxo pipefail

maybe_sudo=

All of the files in the .github subdirectories are only called by CI. We control the CI environment so don't need to do the maybe_sudo check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants