Add http2 routes support #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radito3
reviewed
Nov 9, 2023
| @Nullable | ||
| public abstract Integer getWeight(); | ||
|
|
||
| public abstract String getProtocol(); |
There was a problem hiding this comment.
Shouldn't this be nullable as well? We can return null in the "raw" object when building RouteDestination
There was a problem hiding this comment.
Protocol to use for this destination. Valid protocols are http1 or http2 if route protocol is http, tcp if route protocol is tcp. A null value will set it either http1 or tcp based on the route protocol; this feature is only available if you turn it on in routing release
According to the doc, it should not return null. We use the object only for getting a route, for the creation of the destination requestedProtocol is used
| } | ||
| return currentRoute.getDestinations() | ||
| .stream() | ||
| .noneMatch(routeDestination -> Objects.equals(routeDestination.getApplicationGuid(), applicationGuid) |
There was a problem hiding this comment.
Maybe a cleaner way to do this would be
.stream()
.filter(dest -> Object.equals(dest.appGui(), appGuid))
.noneMatch(dest -> <protocol equality>)
LMCROSSITXSADEPLOY-2647
IvanBorislavovDimitrov
force-pushed
the
http2
branch
from
f51c1d2 to
365726d
Compare
radito3
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LMCROSSITXSADEPLOY-2647