-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
calibrated hlcms incorporated #24
base: semcog
Are you sure you want to change the base?
Conversation
This PR did not run as is. I did my best to bring in things from your other PR that you used in this one without including. My attempt is at pull/24, but it crashes with Can you make a PR that actually runs? |
No, I am checking out the branch from this PR and tried to run. I did guess that you intended me to merge the two PRs, and gave that a try, It seems to be running well. I will look at the results on monday. |
Yes, absolutely right. |
I completed the PR with all the necessary changes to run the simulation with calibrated hlcms. |
Thank you. The model run with my merge completed successfully. We are reviewing. If you have an updated script for doing absolute MSE, I will run it. |
Glad to hear that it ran correctly. I will send the updated script to generate MSE with absolute and perc growth |
Is the new commit a response to my difficulties with #25? Do you want us to checkout that commit and see if we can run it? |
@Eh2406 I have updated the calibrated configs. You can use this branch to run the updated calibrated coefficients. |
Thank you for the update. I was running this commit yesterday, unfortunately the computer rebooted overnite. So I have just restarted it. I will let you know when I get the results. |
This PR is to incorporate calibrated Household location choice models estimated by @janowicz. The HLCMs are large-area controlled and segmented by household type.
The following relevant changes should be included in the master so as to run a Simulation with these new HLCMs.
orca.get_injectable('hlcm_step_names_lacontrol_calib')
replaces the previous hlcm to run the calibrated ones.models.py
lines 83-106: the calibrated yaml file is read and the calibrated hlcms are registered as models.