Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calibrated hlcms incorporated #24

Open
wants to merge 10 commits into
base: semcog
Choose a base branch
from
Open

Conversation

cvanoli
Copy link

@cvanoli cvanoli commented Jul 24, 2019

This PR is to incorporate calibrated Household location choice models estimated by @janowicz. The HLCMs are large-area controlled and segmented by household type.
The following relevant changes should be included in the master so as to run a Simulation with these new HLCMs.

  • Simulation_unitlevel_clustvars.py: orca.get_injectable('hlcm_step_names_lacontrol_calib') replaces the previous hlcm to run the calibrated ones.
  • configs/hlcm_calib/ : this directory holds the yaml files for all large-area/household type calibrated hlcms.
  • models.py lines 83-106: the calibrated yaml file is read and the calibrated hlcms are registered as models.

@Eh2406
Copy link
Contributor

Eh2406 commented Jul 26, 2019

This PR did not run as is. I did my best to bring in things from your other PR that you used in this one without including. My attempt is at pull/24, but it crashes with pandas.core.computation.ops.UndefinedVariableError: name 'hh_type_large_area_id' is not defined.

Can you make a PR that actually runs?

@cvanoli
Copy link
Author

cvanoli commented Jul 27, 2019

Are you including the changes over the last PR changes ? #23?
I assumed you are adding these files and changes to the state of code when you ran unit-level. 8ebf6ac

@Eh2406
Copy link
Contributor

Eh2406 commented Jul 28, 2019

No, I am checking out the branch from this PR and tried to run.
If you wanted a PR that included the changed in 8ebf6ac you could start your branch there. Easily and precisely communicating what exact version code we are talking about is what Git is designed to do. It is a grate tool.

I did guess that you intended me to merge the two PRs, and gave that a try, It seems to be running well. I will look at the results on monday.

@cvanoli
Copy link
Author

cvanoli commented Jul 28, 2019

Yes, absolutely right.
Thanks for doing that. If necessary I will complete this PR properly so it can be read by Itself.

@cvanoli
Copy link
Author

cvanoli commented Jul 29, 2019

I completed the PR with all the necessary changes to run the simulation with calibrated hlcms.

@Eh2406
Copy link
Contributor

Eh2406 commented Jul 29, 2019

Thank you. The model run with my merge completed successfully. We are reviewing. If you have an updated script for doing absolute MSE, I will run it.

@cvanoli
Copy link
Author

cvanoli commented Jul 29, 2019

Glad to hear that it ran correctly. I will send the updated script to generate MSE with absolute and perc growth

@Eh2406
Copy link
Contributor

Eh2406 commented Aug 15, 2019

Is the new commit a response to my difficulties with #25? Do you want us to checkout that commit and see if we can run it?

@cvanoli
Copy link
Author

cvanoli commented Aug 15, 2019

@Eh2406 I have updated the calibrated configs. You can use this branch to run the updated calibrated coefficients.

@Eh2406
Copy link
Contributor

Eh2406 commented Aug 16, 2019

Thank you for the update. I was running this commit yesterday, unfortunately the computer rebooted overnite. So I have just restarted it. I will let you know when I get the results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants