Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify entity version and name validation #91

Merged
merged 7 commits into from
Mar 13, 2024

Conversation

CasperWA
Copy link
Collaborator

@CasperWA CasperWA commented Feb 13, 2024

Fixes #90

The entity version and name validation is unified to be located mainly in the models module, then from there being used in the service - instead of the service having its own special validation implementation.

Note: There's a lot of code duplication in this PR, but this will be remedied by #74.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: Patch coverage is 72.22222% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 90.06%. Comparing base (b2beefc) to head (36f2613).

Files Patch % Lines
entities_service/models/soft.py 70.58% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   90.77%   90.06%   -0.72%     
==========================================
  Files          21       21              
  Lines         954      986      +32     
==========================================
+ Hits          866      888      +22     
- Misses         88       98      +10     
Flag Coverage Δ
docker 70.58% <72.22%> (-0.07%) ⬇️
local 88.74% <72.22%> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CasperWA CasperWA marked this pull request as ready for review February 14, 2024 09:54
@CasperWA CasperWA requested review from quaat and Treesarj February 14, 2024 10:31
@CasperWA CasperWA merged commit adc8e27 into main Mar 13, 2024
9 of 11 checks passed
@CasperWA CasperWA deleted the cwa/fix-90-loosen-name-regex branch March 13, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loosen name regex for retrieving entities
2 participants