Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt dolmen10 #20

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

rod-chapman
Copy link

PR to adopt dolmen v0.10

In particular, this adds option --ext=bvconv that will allow the LibMLKEM benchmarks to be adopted.

@hansjoergschurr
Copy link
Collaborator

Thanks for the pull request!
The last few years we retired the submission repository after the submission process, and created a new repository for the upcoming year. I would used this as an opportunity to update Dolmen and to fix other problems with the CI tooling.

However, I would not adapt --ext=bvconv in the CI script, since this extension is not yet part of the SMT-LIB standard.
This also mean we can't yet include the benchmarks in the main release either. I contacted the SMT-LIB standard maintainers to see whats the current plan around this extension, and to discuss options for presenting such benchmarks.

@rod-chapman
Copy link
Author

OK... let's upgrade the infrastructure to have dolmen0.10 using this PR, then we can return to getting bvconv put into the SMT-LIB standard.

@rod-chapman
Copy link
Author

Does anyone know when we might see an update of the SMT-LIB standard to include the bv2nat stuff?
(Version 2.7 perhaps?)

With my "customer/user" hat on, the bv2nat stuff is as "standard" as anything else, since:

  1. It is generated by widely-used VC generators, particularly the Why3 toolset.
  2. It is accepted and processed by all provers that I care about and use (e.g. Z3, CVC4 and CVC5)
  3. I use it and rely on it to verify real industrial programs every day.

Sounds to me like the standard needs to catch up with industrial practice.

1 similar comment
@rod-chapman
Copy link
Author

Does anyone know when we might see an update of the SMT-LIB standard to include the bv2nat stuff?
(Version 2.7 perhaps?)

With my "customer/user" hat on, the bv2nat stuff is as "standard" as anything else, since:

  1. It is generated by widely-used VC generators, particularly the Why3 toolset.
  2. It is accepted and processed by all provers that I care about and use (e.g. Z3, CVC4 and CVC5)
  3. I use it and rely on it to verify real industrial programs every day.

Sounds to me like the standard needs to catch up with industrial practice.

@hansjoergschurr
Copy link
Collaborator

hansjoergschurr commented Jun 20, 2024

I think a good place to bring this up is the SMT-LIB Google Group. The group is also read by the people who maintain the standard itself (Clark, Pascal, and Cesare).

@barrettcw
Copy link
Member

barrettcw commented Jun 20, 2024 via email

@rod-chapman
Copy link
Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants