Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔍: Upgrade Axios to 1.6.2 to fix the sui-domain and sui-mockmock vulnerabilities #1687

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

nucliweb
Copy link
Member

@nucliweb nucliweb commented Dec 19, 2023

Description

Upgrade Axios to 1.6.2 to fix the sui-domain and sui-mockmock vulnerabilities

@nucliweb nucliweb changed the title feat(packages/sui-domain): upgrade Axios to 1.6.2 in sui-domain 🔍: Upgrade Axios to 1.6.2 to fix the sui-domain and sui-mockmock vulnerabilities Dec 19, 2023
@jordevo
Copy link
Contributor

jordevo commented Dec 19, 2023

did you have a look at potential issues with the upgrade? there's nothing official AFAIK but here's some crowd-sourced documentation / guide: https://github.com/bmuenzenmeyer/axios-1.0.0-migration-guide

@nucliweb
Copy link
Member Author

did you have a look at potential issues with the upgrade? there's nothing official AFAIK but here's some crowd-sourced documentation / guide: https://github.com/bmuenzenmeyer/axios-1.0.0-migration-guide

Thanks @jordevo, we don't use the @bundled-es-modules/axios package

@jordevo
Copy link
Contributor

jordevo commented Dec 19, 2023

did you have a look at potential issues with the upgrade? there's nothing official AFAIK but here's some crowd-sourced documentation / guide: https://github.com/bmuenzenmeyer/axios-1.0.0-migration-guide

Thanks @jordevo, we don't use the @bundled-es-modules/axios package

not sure I'm following... the non-official migration guide refers to the axios package

@nucliweb
Copy link
Member Author

did you have a look at potential issues with the upgrade? there's nothing official AFAIK but here's some crowd-sourced documentation / guide: https://github.com/bmuenzenmeyer/axios-1.0.0-migration-guide

Thanks @jordevo, we don't use the @bundled-es-modules/axios package

not sure I'm following... the non-official migration guide refers to the axios package

We import Axios from Axios, not from @bundled-es-modules/axios

image

https://github.com/SUI-Components/sui/blob/feat%2Fupgrade-domain-to-axios-1.6.2/packages/sui-domain/src/fetcher/AxiosFetcher.js#L1

@nucliweb nucliweb merged commit 023cc84 into master Dec 19, 2023
1 check passed
@nucliweb nucliweb deleted the feat/upgrade-domain-to-axios-1.6.2 branch December 19, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants