Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add memory/CPU limit, and parameters to docker run #8

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add memory/CPU limit, and parameters to docker run #8

wants to merge 3 commits into from

Conversation

thomasyu888
Copy link
Contributor

@thomasyu888 thomasyu888 commented Apr 29, 2021 •
edited
Loading

  • Add in memory + CPU parameters (implement CPU limitation)
  • Don't rely on hardcoded paths in the model, require the model to take --input and --output parameters.
  • Remove status check in run docker step

@thomasyu888 thomasyu888 requested a review from vpchung March 8, 2022 11:27
vpchung
vpchung approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@vpchung vpchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor comment.

run_docker.py
mem_limit='6g', stderr=True)
container = client.containers.run(
docker_image,
"--input /data --output /output",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We normally specify the input directory as /input -- should we update the template to /data instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these need to be parameters to the cwl file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpchung vpchung vpchung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasyu888 @vpchung