feat(agora): agora fixes (AG-1604) and Q4 2024 changes (AG-1605) #2955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagely1
changed the title
sagely1
changed the title
sagely1
commented
Jan 5, 2025
sagely1
commented
Jan 5, 2025
libs/agora/genes/src/lib/components/gene-resources/gene-resources.component.html
Show resolved
Hide resolved
hallieswan
reviewed
Jan 6, 2025
libs/agora/shared/src/lib/loading-overlay/loading-overlay.component.html
Outdated
Show resolved
Hide resolved
libs/agora/shared/src/lib/loading-overlay/loading-overlay.component.ts
Outdated
Show resolved
Hide resolved
tschaffter
reviewed
Jan 6, 2025
libs/agora/genes/src/lib/components/gene-hero/gene-hero.component.html
Outdated
Show resolved
Hide resolved
tschaffter
reviewed
Jan 6, 2025
tschaffter
reviewed
Jan 6, 2025
sagely1
commented
Jan 9, 2025
sagely1
commented
Jan 9, 2025
sagely1
commented
Jan 9, 2025
tschaffter
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a collection of fixes found during manual testing (AG-1604)
This also incorporates changes from Q4 2024 (AG-1605)
Fixes
Fixed GCT loading animation was not displaying when loading the page. New CSS was written to support the new standalone component.
Download chart functionality was not working with FireFox (image was being cut off at arbitrary dimensions) and the latest download-dom-image-more package. It is a known issue so the width and height are now being explicitly passed to maintain cross-compatibility.
Example issue:
Due to the removal of Bootstrap, the Resources tab in Gene Details was not displaying the resource cards properly so new CSS was written to achieve a similar effect. The original code has element inconsistently aligned either left or center so this has been updated to left justified.
Original:
New:
