Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agora): fix shared-typescript-angular-charts:test target after Angular update (AG-1610) #2960

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

hallieswan
Copy link
Collaborator

Description

Fixes the shared-typescript-angular-charts:test target that was failing after the monorepo update to Angular 19, see discussion here.

Example output from nx run shared-typescript-angular-charts:test:

 PASS   shared-typescript-charts-angular  libs/shared/typescript/charts-angular/src/lib/boxplot/boxplot.directive.spec.ts (5.366 s)
  BoxplotDirective
    ✓ should render no data placeholder when no data is passed (369 ms)
    ✓ should render boxplot with static summaries (133 ms)
    ✓ should render boxplot with dynamic summaries (101 ms)

----------------------|---------|----------|---------|---------|-------------------
File                  | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
----------------------|---------|----------|---------|---------|-------------------
All files             |     100 |      100 |     100 |     100 |                   
 boxplot.directive.ts |     100 |      100 |     100 |     100 |                   
----------------------|---------|----------|---------|---------|-------------------
Test Suites: 1 passed, 1 total
Tests:       3 passed, 3 total
Snapshots:   0 total
Time:        6.997 s, estimated 10 s
Ran all test suites.

—————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————

 NX   Successfully ran target test for project shared-typescript-charts-angular (196ms)

@hallieswan hallieswan marked this pull request as ready for review January 9, 2025 23:38
@hallieswan hallieswan requested a review from tschaffter as a code owner January 9, 2025 23:38
@hallieswan hallieswan requested review from sagely1 and removed request for sagely1 January 10, 2025 01:14
@tschaffter tschaffter merged commit 921c0bb into Sage-Bionetworks:main Jan 10, 2025
12 of 13 checks passed
@hallieswan hallieswan deleted the agora/AG-1610 branch January 10, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants