Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases for verifying flags used to tweak behaviour of deploy #29

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add test cases for verifying flags used to tweak behaviour of deploy #29

wants to merge 6 commits into from

Conversation

Srijan-SS02
Copy link
Collaborator

@Srijan-SS02 Srijan-SS02 commented Jul 7, 2024 •
edited
Loading

#28

  • Added test for ENABLE_FORCE_RECREATE

Screenshot from 2024-07-07 09-22-32

@Srijan-SS02 Srijan-SS02 requested a review from singhalkarun July 7, 2024 04:57
@Srijan-SS02
Copy link
Collaborator Author

Srijan-SS02 commented Jul 8, 2024 •
edited
Loading

Screenshot from 2024-07-08 13-46-26

All test running

@Srijan-SS02 Srijan-SS02 changed the title [DRAFT] Add test cases for verifying flags used to tweak behaviour of deploy Add test cases for verifying flags used to tweak behaviour of deploy Jul 8, 2024
@singhalkarun
Copy link
Collaborator

@Srijan-SS02 let's figure out ways to mock make targets instead of actually running make deploy.

@Srijan-SS02
Copy link
Collaborator Author

Hi @singhalkarun, I have updated PR with mock_test.bats. I have tried to mock the Makfile for this you can check it in Makefile.mock.
If you find the approach to be correct, I can further add tests for all the flags?

@Srijan-SS02
Copy link
Collaborator Author

@singhalkarun, I Have not deleted the test.bats file, as it can be used for integration testing occasionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@singhalkarun singhalkarun Awaiting requested review from singhalkarun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Srijan-SS02 @singhalkarun