Fitting widget refactor #3169
Open
Fitting widget refactor #3169
+1,379
−1,242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated for ver. 6.0 release source and with PR raised issues addressed.
|
macos-latest fails due to a know issue with binary signing. #3134 |
|
@rozyczko - there's conflicts to resolve |
krzywon
reviewed
Jan 10, 2025
| # make sure the logic contains at least one element | ||
| assert self._logic | ||
| # logic connected to the currently shown data | ||
| return self._logic[self.data_index] | ||
|
|
||
| @property | ||
| def data(self): | ||
| def data(self) -> Union[Data1D, Data2D]: |
There was a problem hiding this comment.
nitpick: The setter accepts lists, but the getter only returns single data objects?
| # add polydisperse parameters if asked | ||
| if self.isActive and self.poly_model.rowCount() > 0: | ||
| for key, value in self.poly_params.items(): | ||
| model.setParam(key, value) |
There was a problem hiding this comment.
After switching from core_multi_shell with polydispersity enabled to sphere, I get the following error when I try to calculate the model. This does not happen in v6.0:
ValueError: Model does not contain parameter thickness1.width
There was a problem hiding this comment.
All issues addressed (+ some more found out during testing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the refactoring effort, the same as in #2651 but reparented to the current
main.All issues raised by @krzywon in the original PR have been addressed.
Additionally, the files involved in the refactor were "improved" by
ruff(runningruff check)This is part 1 of the refactoring, focused on the two biggest and most independent components.
Next, I will attempt to refactor out constraints to a separate module.
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licencing (untick if necessary)