Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calls to set_xticklabels and set_yticklabels #3191

Open
wants to merge 1 commit into
base: release_6.0.1
Choose a base branch
from

Conversation

jamescrake-merani
Copy link
Contributor

Description

Fixes #3189

How Has This Been Tested?

Followed the reproduction steps in the issue, and the error no longer appears.

@butlerpd can you please confirm that the intended behaviour now occurs? If you run SasView from this branch, please ignore any errors with 'NameError: name 'model_id' is not defined'; I have fixed these in a separate PR.

Review Checklist:

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

Copy link
Contributor

@krzywon krzywon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. Code LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants