Remove katello-agent from entities and views #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsedmik
added
entity
|
trigger: test-robottelo |
Gauravtalreja1
approved these changes
Oct 16, 2023
| @@ -102,8 +101,6 @@ def manage_packages( | |||
| view.apply_action(action, action_via=action_via) | |||
| view.flash.assert_no_error() | |||
| view.flash.dismiss() | |||
| if action_via == 'via Katello Agent': | |||
| view.done.click() | |||
| if action_via == 'via remote execution - customize first': | |||
| # After this step the user is redirected to remote execution job | |||
| # create view. | |||
There was a problem hiding this comment.
line number 114 or 111 conditional statement if action_via in ('via remote execution', 'via remote execution - customize first'): also can be removed.
There was a problem hiding this comment.
Yeah I think it could, good catch!
|
some more places you are missing this @vsedmik will you covering them this PR ? |
sambible
approved these changes
Oct 18, 2023
|
Addressed Omkar's comment, rebased. |
omkarkhatavkar
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Katello agent was deprecated and is being removed from 6.15, the functionality will be replaced by REX.
This PR removes references from entities and views.