Added possibility to search for debian errata #1013
Conversation
|
Can one of the admins verify this patch? |
airgun/views/errata.py
Outdated
| @@ -40,7 +40,7 @@ def search(self, query, applicable=True, installable=False, repo=None): | |||
| if repo is not None: | |||
| self.repo_filter.fill(repo) | |||
|
|
|||
| if re.search(r'\w{3,4}[:-]\d{4}[-:]\d{4}', query): | |||
| if re.search(r'\w{3,4}[:-]\d{4}[-:]\d{1,4}', query): | |||
There was a problem hiding this comment.
@sambible @vsedmik @vijaysawant Do you see any value for this regex? As per I know we never use the Debian errata, mostly test RHEL errata.
There was a problem hiding this comment.
We don't test any Debian errata that I'm aware of. This will change this particular regex to allow for
DSA-1234-1 where in the past it would not have matched, since RHEL errata are in the form
RHSA-1234-1234 ( With explicitly 4 characters in the last third)
These will still get captured by this adjusted regex, although it won't match them as strictly. If there's value to @dosas here, I'd be curious to know the use case
There was a problem hiding this comment.
My use case is to read and install debian errata with robottelo which currently is not possible since the search is a requirement for the ErrataDetailsView
There was a problem hiding this comment.
Upon writing the above comment I realized that the same regexp is also used for this view .
I pushed a fix that will store the information in one place.
in the form DSA-1234-1
dosas
force-pushed
the
feature/debian-errata
branch
from
1d853c9 to
6ea95f0
Compare
|
@dosas We require additional time to thoroughly test this. I will need to conduct additional PRT tests to ensure that no issues arise. Since you are not an organization user, you do not have the ability to trigger the PRT tool. We are interested in exploring alternative testing methods that do not rely on permissions. |
|
@omkarkhatavkar I don't think PRT will help us here, aside from basic regression testing, since debian isn't supported by Satellite. This would need to be tested in an upstream build. |
|
@JacobCallahan As you said rightly, running PRT to ensure regression is passing and we will have to ask the anyone from the Phonix team to test this with an upstream build. I guess @sambible @vsedmik @ColeHiggins2 could help. |
|
any news on this? |
sambible
added
CherryPick
|
trigger: test-robottelo |
|
@dosas we are going to run some tests in PRT here, and if we see passes then I'm good with approving this request |
|
trigger: test-robottelo |
|
I see that some tests are failing. Let me know if this is related to the change and I should fix something. |
in the form DSA-1234-1 (cherry picked from commit 6cef8cc)
|
@vsedmik I saw that you removed cherry pick labels for 6.14 and 6.13 is there any strong reason for this. Would it be possible to cherry pick it into those branches? |
|
@dosas oh no, it was a mid-air collision. I just added |
in the form DSA-1234-1 (cherry picked from commit 6cef8cc) Co-authored-by: dosas <[email protected]>
|
@vsedmik what would we have to do to get these changes to 6.13.z and 6.14.z |
in the form DSA-1234-1
in the form DSA-1234-1
in the form DSA-1234-1
in the form DSA-1234-1