-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing updated value and takes default value #1643
removing updated value and takes default value #1643
Conversation
d12b491
to
add4e64
Compare
PRT Result
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change requested, otherwise looks good to me. GJ @amolpati30!
add4e64
to
1a3b6db
Compare
PRT Result
|
PRT Result
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Is there a reason why each of these functions isn't an atomic function? Is it important to read RIGHT AFTER updating/deleting? |
@lhellebr |
Let me rephrase my question. Let's take one of the functions: |
Thank you for the clarification. I would suggest that if we are deleting/updating value, we should read the value for verification/assertion purposes. I have already added this functionality in the method. However, creating a separate method specifically for reading the value is also a good idea. This way, we could have two methods for update/delete operations and a third method to handle reading the value. Do you think I should update the implementation accordingly? |
I think yes, if you don't have a specific reason to make those inherently atomic operations a single operation in this case. I think that's also the way we have it everywhere else. |
1a3b6db
to
4c3e1ea
Compare
4c3e1ea
to
c8c8d8a
Compare
PRT Result
|
trigger: test-robottelo |
PRT Result
|
Added to the entities with their respective locators:
update_variable_value
: Updating the ansible variable value in the host.del_variable_value
: Deletes the updated value, reverts to the default value.read_variable_value
: Read the value of ansible variable in the host.Dependent PR: SatelliteQE/robottelo#16969