Pagination refactor #947
Merged
Pagination refactor #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstrlc
added
6.12.z
CherryPick
mstrlc
force-pushed
the
pagination-refactor
branch
from
299014d to
25d0a68
Compare
|
|
trigger: test-robottelo |
|
@mstrlc Can you please resolve the conflicts and run test manually or dummy PR from PRT |
mstrlc
force-pushed
the
pagination-refactor
branch
from
25d0a68 to
53a1ccf
Compare
|
Fixed Pagination in SatTable to not break existing code. Tested manually, found everything works as it should. Running PRT in Robottelo PR with a dummy test. |
|
PRT pass. |
omkarkhatavkar
approved these changes
Nov 9, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 9, 2023
* update views to use Widgetastic's PF4 Pagination * rename to PF4Pagination * fix SatTable locator * add Pagination to location for testing * pre-commit (cherry picked from commit cd24e60)
This was referenced Nov 9, 2023
mstrlc
added a commit
to mstrlc/airgun
that referenced
this pull request
Nov 14, 2023
* update views to use Widgetastic's PF4 Pagination * rename to PF4Pagination * fix SatTable locator * add Pagination to location for testing * pre-commit
mstrlc
added a commit
to mstrlc/airgun
that referenced
this pull request
Nov 14, 2023
* update views to use Widgetastic's PF4 Pagination * rename to PF4Pagination * fix SatTable locator * add Pagination to location for testing * pre-commit
omkarkhatavkar
pushed a commit
that referenced
this pull request
Nov 16, 2023
* update views to use Widgetastic's PF4 Pagination * rename to PF4Pagination * fix SatTable locator * add Pagination to location for testing * pre-commit (cherry picked from commit cd24e60) Co-authored-by: Matyáš Strelec <[email protected]>
omkarkhatavkar
pushed a commit
that referenced
this pull request
Nov 16, 2023
omkarkhatavkar
pushed a commit
that referenced
this pull request
Nov 16, 2023
damoore044
pushed a commit
to damoore044/airgun
that referenced
this pull request
Jan 12, 2024
* update views to use Widgetastic's PF4 Pagination * rename to PF4Pagination * fix SatTable locator * add Pagination to location for testing * pre-commit
This was referenced Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to refactor Pagination in Airgun.
First step with this commit is to change Pagination in individual views to Widgetastic's implementation. It's methods should be compatible with Airgun's existing Pagination widget, so no need to change code that uses it.
Next step is to look into
SatTableand it's Pagination.