-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the Container Image Tags page view #999
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please try by running it locally with below changes in column_widgets variable ?
table = SatTable('.//table', column_widgets={'<Column Name>': Text('.//a')})
I am not sure changes made for Table
(in this PR "fix bad table row locator") would be applicable for SatTable
use in your code
|
||
@View.nested | ||
class lce(SatTab): | ||
TAB_NAME = 'Lifecycle Environments' | ||
table = SatTable( | ||
'.//table', | ||
column_widgets={'Environment': Text('./a'), 'Content View Version': Text('./a')}, | ||
column_widgets={ | ||
'Environment': Text('./a'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look into this reference PR "fix bad table row locator" raised by @sambible
'Environment': Text('.//a')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although both options work, after off-line communication we decided to keep the current version.
@vsedmik Do you have the PRT test result or test result for this? |
@omkarkhatavkar looks like PRT passed on SatelliteQE/robottelo#12848 |
(cherry picked from commit 8c1e7eb)
(cherry picked from commit 8c1e7eb) Co-authored-by: vsedmik <[email protected]>
In 6.14 and later the structure of the
Container Image Tags
page has been changed - repository was removed from theDetails
tab and a newRepositories
tab was added.For reference: Katello/katello#10533
This PR updates the view accordingly.