Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Container Image Tags page view #999

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Oct 9, 2023

In 6.14 and later the structure of the Container Image Tags page has been changed - repository was removed from the Details tab and a new Repositories tab was added.

For reference: Katello/katello#10533

This PR updates the view accordingly.

@vsedmik vsedmik added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing 6.14.z labels Oct 9, 2023
@vsedmik vsedmik self-assigned this Oct 9, 2023
Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please try by running it locally with below changes in column_widgets variable ?
table = SatTable('.//table', column_widgets={'<Column Name>': Text('.//a')})

I am not sure changes made for Table (in this PR "fix bad table row locator") would be applicable for SatTable use in your code


@View.nested
class lce(SatTab):
TAB_NAME = 'Lifecycle Environments'
table = SatTable(
'.//table',
column_widgets={'Environment': Text('./a'), 'Content View Version': Text('./a')},
column_widgets={
'Environment': Text('./a'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look into this reference PR "fix bad table row locator" raised by @sambible

'Environment': Text('.//a')

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although both options work, after off-line communication we decided to keep the current version.

@omkarkhatavkar
Copy link

@vsedmik Do you have the PRT test result or test result for this?

@Griffin-Sullivan
Copy link
Contributor

@omkarkhatavkar looks like PRT passed on SatelliteQE/robottelo#12848

@omkarkhatavkar omkarkhatavkar merged commit 8c1e7eb into SatelliteQE:master Oct 20, 2023
2 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 20, 2023
Gauravtalreja1 pushed a commit that referenced this pull request Oct 20, 2023
(cherry picked from commit 8c1e7eb)

Co-authored-by: vsedmik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants