Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for backup and restore in proxmox-ve gui #45

Closed
wants to merge 4 commits into from
Closed

add support for backup and restore in proxmox-ve gui #45

wants to merge 4 commits into from

Conversation

blecher-at
Copy link

I made backup work. I am quite new to nix, so not sure I did everything correctly.
Backup and restore requires quite the dependencies, and patching ... but this PR might be a starting point.

blecher-at
blecher-at commented Jul 27, 2024
View reviewed changes
modules/proxmox-ve/manager.nix
@@ -145,6 +145,15 @@ lib.mkIf config.services.proxmox-ve.enable {
};
};

qmeventd = {
Copy link
Author

@blecher-at blecher-at Jul 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can probably be removed once #41 is merged...

blecher-at
blecher-at commented Jul 27, 2024
View reviewed changes
pkgs/pve-manager/default.nix
@@ -108,7 +113,9 @@ perl536.pkgs.toPerlModule (
-e "s|/usr/share/zoneinfo|${tzdata}/share/zoneinfo|" \
-e "s|/usr/share/pve-xtermjs|${pve-xtermjs}/share/pve-xtermjs|" \
-Ee "s|(/usr)?/s?bin/||" \
-e "s|/usr/share/novnc-pve|${pve-novnc}/share/webapps/novnc|"
-e "s|/usr/share/novnc-pve|${pve-novnc}/share/webapps/novnc|" \
-e "s|/usr/share/perl5/.plug|${pve-qemu-server}/${perl536.libPrefix}/${perl536.version}/\$plug|"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably better to patch the plugin-logic (PVE/VZDump.pm:45) instead, as this currently wont support lxc containers.

@JulienMalka
Copy link
Member

This looks good thanks ! If you could rebase to fix conflicts that'd great.

norpol
norpol reviewed Nov 21, 2024
View reviewed changes
pkgs/cstream/default.nix
sha256 = "sha256-a8BtfEOG+5jTqRcTQ0wxXZ5tQlyRyIYoG+qiVMDgluM=";
};

buildInputs = [ stdenv.cc ];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want to use nativeBuildInputs as cc will not be needed during runtime?

@greg-hellings
Copy link

Anything I can do to help get this merged in? Having a fix for backups would be great, even if there are caveats.

@JulienMalka
Copy link
Member

@greg-hellings If you could test it and confirm it works it would already go a long way :)

@greg-hellings
Copy link

@JulienMalka Previously it immediately died without the ability to find sendmail. Now it gets farther, but still fails.
image

I believe comments above mention the missing service is addressed in a still Draft PR.

@greg-hellings
Copy link

Looks like that might have been a false negative. Since I already had pve-guests running, it wasn't auto-started when I did a rebuild and switch. Doing a rebuild and reboot gives me a successful backup run. It still outputs an error at the end trying to send emails, but the backup does run successfully.

image

@pio2398
Copy link

pio2398 commented Jan 1, 2025

I tried to rebase this PR and try it out but I have that problem:


()
INFO: starting new backup job: vzdump --compress zstd --fleecing 0 --node nixos-host --mode snapshot --storage local --all 1 --notes-template '{{guestname}}' --prune-backups 'keep-last=10'
ERROR: Backup of VM 100 failed - unable to find VM '100'
INFO: Failed at 2025-01-01 12:57:05
ERROR: Backup of VM 101 failed - unable to find VM '101'
INFO: Failed at 2025-01-01 12:57:05
ERROR: Backup of VM 102 failed - unable to find VM '102'
INFO: Failed at 2025-01-01 12:57:05
ERROR: Backup of VM 103 failed - unable to find VM '103'
INFO: Failed at 2025-01-01 12:57:05
ERROR: Backup of VM 104 failed - unable to find VM '104'
INFO: Failed at 2025-01-01 12:57:05
INFO: Backup job finished with errors
ERROR: could not notify via target `mail-to-root`: could not load template 'vzdump'
TASK ERROR: job errors

@mjm mjm mentioned this pull request Jan 1, 2025
Open
@blecher-at
Copy link
Author

blecher-at commented Jan 14, 2025 •
edited
Loading

I tried to rebase this PR and try it out but I have that problem:

Sorry for not getting back on this earlier. I just got a new mainboard for the server today, as that nix-system had a hardware failure. Will hopefully be able to retest over the next few days.

#113 seems to be the updated PR. so I am closing this one.

@blecher-at blecher-at closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norpol norpol norpol left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@blecher-at @JulienMalka @greg-hellings @pio2398 @norpol