Tests that fail for BlueWallet-v7.0.7 upper-cased addresses #666
+16
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdmukai
reviewed
Jan 20, 2025
| @@ -297,6 +297,9 @@ def test_bitcoin_address(): | |||
|
|
|||
| main_bech32_address2 = "bitcoin:bc1qar0srrr7xfkvy5l643lydnw9re59gtzzwf5mdq?amount=12000" | |||
| main_bech32_address3 = "BITCOIN:bc1qar0srrr7xfkvy5l643lydnw9re59gtzzwf5mdq?junk" | |||
| main_bech32_address4 = "bitcoin:BC1QAR0SRRR7XFKVY5L643LYDNW9RE59GTZZWF5MDQ?junk" | |||
| main_bech32_address5 = "BITCOIN:BC1QAR0SRRR7XFKVY5L643LYDNW9RE59GTZZWF5MDQ?junk" | |||
| main_bech32_address6 = "BC1QAR0SRRR7XFKVY5L643LYDNW9RE59GTZZWF5MDQ" | |||
There was a problem hiding this comment.
Suggest refactoring to something like:
bech32_capitalization_variations = [
"bitcoin:...",
"BITCOIN:...",
]And simplifying the for:
for capitalization_variation in bech32_capitalization_variations:
...The main_bech32_address2 test down on lines 358-362 can be removed since it's now redundant. With that removed, there's no need for the var name.
|
While we're editing this file, can we rename it to As I was altering the bitcoin addr decoding logic, I was looking for a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolves #665
Recently released BlueWallet v7.0.7 changed their bech32 address format for qr-codes.
BlueWallet/BlueWallet#7461
2 commits that add failing test-cases for latest BlueWallet v7.0.7 bech32 addresses that look like "bitcoin:BC1Q..."
TODO: resolve models/decode_qr.py to support uppercased bech32 addresses and avoids future BlueWallet user complaints about not being able to verify addresses.
This pull request is categorized as a:
Checklist
pytestand made sure all unit tests pass before sumbitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os:
Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.