Chrome manifest v3 updates #19
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…come ERR_OSSL_EVP_UNSUPPORTED build error due to node version being too new
This is not strictly required for V3 Chrome Extension, but it is the more modern way of handling calls to the async local storage API
…dards main changes were: Removal of the oldChromeVersion checks and related code Simplification of the alarm handling Changes to the initialization and startup logic
… Chrome V3 Extension Manifest but required by Firefox See more here: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/background#browser_support
This reverts commit 25a0da8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the code of the Torah Tab extension to comply with Google V3 Manifest requirements.
It mainly consisted of updating the manifest file according to the instructions at https://developer.chrome.com/docs/extensions/develop/migrate/manifest and updating the code.
Most of the code didnt seem to need changes, including
main.jsanddataApi.js, though the latter had some syntax changes made to some local storage calls to make it more modern.background.jswas updated to simplify out old legacy code and rework it as a service worker, making sure there are no invalid calls there.