Merge pull request #2113 from Sefaria/slack-secret-ref

fix: move slack env declaration out of otel logic
Sefaria · Nov 17, 2024 · 0a4c572 · 0a4c572
2 parents 6898a18 + 9c3acf5
commit 0a4c572
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/helm-chart/sefaria-project/templates/rollout/web.yaml b/helm-chart/sefaria-project/templates/rollout/web.yaml
@@ -116,12 +116,12 @@ spec:
                 fieldPath: spec.nodeName
           - name: OTEL_RESOURCE_ATTRIBUTES
             value: k8s.container.name=app,k8s.deployment.name={{ .Values.deployEnv }}-web,k8s.namespace.name={{ .Release.Namespace }},k8s.node.name=$(OTEL_RESOURCE_ATTRIBUTES_NODE_NAME),k8s.pod.name=$(OTEL_RESOURCE_ATTRIBUTES_POD_NAME)
+          {{- end }}
           - name: SLACK_URL
             valueFrom:
               secretKeyRef:
-                name: { { template "sefaria.secrets.slackWebhook" . } }
+                name: {{ template "sefaria.secrets.slackWebhook" . }}
                 key: slack-webhook
-          {{- end }}
         envFrom:
           {{- if .Values.tasks.enabled }}
           - secretRef: