chore: change a tag to button

Sefaria · Jan 14, 2025 · c2f8baa · c2f8baa
1 parent 1fe0859
commit c2f8baa
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/static/css/s2.css b/static/css/s2.css
@@ -4987,6 +4987,8 @@ body .ui-autocomplete.dictionary-toc-autocomplete .ui-menu-item a.ui-state-focus
   display: flex;
 }
 .readerControls .readerControlsInner.transLangPrefSuggBannInner .yesNoButton {
+  border: none;
+  font-size: 16px;
   border-radius: 6px;
   background-color: white;
   padding: 5px 11px;

diff --git a/static/js/TextColumnBanner.jsx b/static/js/TextColumnBanner.jsx
@@ -145,8 +145,8 @@ const TextColumnBannerButton = ({ button, closeBanner }) => {
         if (button.sideEffect === "close") { closeBanner(true); }
     }
     return (
-        <a href="#" role="button" tabIndex="0" className="yesNoButton" aria-label={button.text} onClick={onClick}>
+        <button tabIndex="0" className="yesNoButton" aria-label={button.text} onClick={onClick}>
             <InterfaceText>{button.text}</InterfaceText>
-        </a>
+        </button>
     );
 }