Update drop drown for logged in desktop (library) #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… icon instead of link
edamboritz
reviewed
Oct 1, 2024
static/js/Header.jsx
Outdated
| <DropdownMenuItemWithIcon icon={'/static/icons/library_icon.svg'} textEn={'Library'} textHe={'ספריה'} /> | ||
| </DropdownMenuItem> | ||
| <DropdownMenuSeparator /> | ||
| <DropdownMenuItem url={'//sheets.sefaria.org'}> | ||
| <DropdownMenuItem url={'//sheets.sefaria.org'} newTab={true}> |
There was a problem hiding this comment.
What are these double slashes?
There was a problem hiding this comment.
To make the URL not relative (i.e. route to sheets.sefaria.org vs localhost:8000/sheets.sefaria.org). It's a bit hacky, is there a better way to do this?
There was a problem hiding this comment.
Might be /sheets, confirm with SK.
static/icons/logged_out.svg
Outdated
There was a problem hiding this comment.
Why is this icon in this PR if the PR is for logged in menu?
There was a problem hiding this comment.
Mistake, taking out. Thanks for catching :)
saengel
commented
Nov 11, 2024
static/js/Header.jsx
Outdated
| <DropdownMenuItemWithIcon icon={'/static/icons/sheets_icon.svg'} textEn={'Sheets'} textHe={'דפים'}/> | ||
| </DropdownMenuItem> | ||
| <DropdownMenuSeparator /> | ||
| <DropdownMenuItem url={'//developers.sefaria.org'}> | ||
| <DropdownMenuItem url={'//developers.sefaria.org'} newTab={true}> |
…s of logged-out dropdown, clean up urls
saengel
requested review from
edamboritz and
yitzhakc
and removed request for
akiva10b
edamboritz
approved these changes
Nov 20, 2024
saengel
deleted the
feature/sc-27509/library-update-drop-drown-for-logged-in-desktop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the user drop down for library logged-in view.
Code Changes
static/css/s2.css- CSS shifts to get everything working, tested to make sure it doesn't break anything. Commenting out the chevron dropdown (see note below)static/icons/logged_out.svg- The icon for logged out users.static/js/Header.jsx- The new logged in dropdown component (<LoggedInDropdown />), rendering it. Fixes also to the module switcher to jive with the adjustment to<DropdownMenu />static/js/common/DropdownMenu.jsx- Adjusting the dropdown menu component to flexibly allow opening in new tabs vs same window, and accepting an icon component instead of a url for more flexibility.Notes
<DropdownMenu />component, accepting the icon image (from which the dropdown 'hangs') as a component instead of a url string. This allows for greater flexibility when rendering components like the initials icon. We will need to likely shift some small pieces in other PRs for everything to merge seamlessly, but it should be fairly easy.