Feature/sc 27825/add to sheet2 #2179
Open
+400
−474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/sc-27825/add-to-sheet
…e/sc-27825/add-to-sheet
…e/sc-27825/add-to-sheet
…e/sc-27825/add-to-sheet
…e/sc-27825/add-to-sheet
This reverts commit f3d7ed5.
…s so I can style it appropriately
…e/sc-27825/add-to-sheet
…e/sc-27825/add-to-sheet
…-27825/add-to-sheet
…e/sc-27825/add-to-sheet
…e/sc-27825/add-to-sheet
…e/sc-27825/add-to-sheet
…e/sc-27825/add-to-sheet
…re/sc-27825/add-to-sheet2
…re/sc-27825/add-to-sheet2
…re/sc-27825/add-to-sheet2
…re/sc-27825/add-to-sheet2
…re/sc-27825/add-to-sheet2
Feature/sc 27826/styling
yitzhakc
requested changes
Jan 8, 2025
| data-node={this.props.source.node} | ||
| aria-label={"Click to see connections to this source"} | ||
| tabIndex="0" | ||
| onKeyPress={function(e) { |
There was a problem hiding this comment.
It looks like this function is duplicated a few times, can we re-use it?
There was a problem hiding this comment.
I added a prop handleKeyPress to deal with this case
static/js/sheets/SheetContent.jsx
Outdated
| let ComponentToRender; | ||
| if ("ref" in source) { | ||
| const highlightedRef = this.props.highlightedRefsInSheet ? Sefaria.normRefList(this.props.highlightedRefsInSheet) : null; | ||
| highlighted = highlightedNode ? highlightedNode === source.node : highlightedRef ? Sefaria.refContains(source.ref, highlightedRef) : false; |
There was a problem hiding this comment.
this is dufficult to follow
…re/sc-27825/add-to-sheet2
stevekaplan123
changed the base branch from
feature/sc-27328/options-popover-component2
to
feature/sc-27327/source-click-should-open-in-new-tab2
…into feature/sc-27825/add-to-sheet2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The feature this PR implements is that it attaches an "Add to Sheet" button to every segment of the sheet. The button is hidden, but when the user clicks on the segment, the "Add to Sheet" button appears. After the user clicks the "Add to Sheet" button, a modal appears allowing the user to select which of the user's sheets to add the segment to.
Code Changes