Bug/sc 26322/click on commentary in search version name #2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, handle version info properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From search results, commentaries would not open properly. First, the version of the commentary would show as the version of the base text in the URL. Second, the version of the commentary would not get applied in the connections panel. Both issues are now fixed.
Code Changes
The solution is to create a new panel prop
currCommVersionswhich is a object whose properties are titles of texts and the corresponding values are the versions we want for each of those texts. If the Connections Panel has a field for the current book in the Connections Panel, it passes down the version information to TextList which in turn passes currVersions down to TextRange and OpenConnectionTabButton so that (1) TextRange now loads the right text with currVersions and (2) if the user clicks to open the connection, it opens in a panel with currVersions set properly.