Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sheets][Desktop] My Profile #2210

Conversation

saengel
Copy link
Contributor

@saengel saengel commented Jan 2, 2025

Description

Aligning the profile page on sheets to the updated spec

Code Changes

  1. static/css/s2.css - Aligning styles with spec.
  2. static/js/Misc.jsx - Removing icons, topic tags from SheetListing and CollectionListing
  3. static/js/UserProfile.jsx - Removing and rearranaging according to spec, removing filter and search on list items.

Notes

  • Some outstanding font questions to be cleared up

@saengel saengel requested a review from yitzhakc January 2, 2025 19:36
@saengel saengel self-assigned this Jan 2, 2025
static/css/s2.css Outdated Show resolved Hide resolved
Copy link
Contributor

@yitzhakc yitzhakc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't see anything else right now

@saengel saengel requested a review from yitzhakc January 8, 2025 08:47
@yitzhakc yitzhakc merged commit 3bc9650 into modularization-main Jan 9, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants