-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ProcessHandler: Make timeout of stream_select()
configurable
#1916
Conversation
In our application, any request has always been blocked for 1 second and made it significantly slower. Rather than needing to overwrite almost the entire class with a custom implementation, it would be nice to have this timeout configurable.
@Seldaek What would be required to move this forward? :) |
Do you use ProcessHandler in prod? What for? Just out of curiosity sorry.. Anyway the PR seems fine so I'll merge but I'll need some more free time before I can triage other stuff and tag a release. |
No worries, thanks for picking this up! :) We use the ProcessHandler for redirecting some logs to the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion to allow passing a float as timeout so you can set microseconds too, because just having 0 or 1 is not allowing for a lot of precision.
Co-authored-by: Jordi Boggiano <[email protected]>
Alright, thanks |
In our application, any request has always been blocked for 1 second and made it significantly slower. Rather than needing to overwrite almost the entire class with a custom implementation, it would be nice to have this timeout configurable.