Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON load #52

Merged
merged 3 commits into from
May 12, 2020
Merged

JSON load #52

merged 3 commits into from
May 12, 2020

Conversation

someshsingh22
Copy link
Member

@someshsingh22 someshsingh22 commented May 12, 2020 •
edited
Loading

Commit 1 - Json loading enabled
Commit 2 - Universal Path used
Commit 3 - Merged with prior conflicting pulls

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@someshsingh22 someshsingh22 marked this pull request as ready for review May 12, 2020 11:37
@codecov
Copy link

codecov bot commented May 12, 2020 •
edited
Loading

Codecov Report

Merging #52 into master will increase coverage by 0.79%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   91.32%   92.12%   +0.79%     
==========================================
  Files           6        6              
  Lines         173      165       -8     
==========================================
- Hits          158      152       -6     
+ Misses         15       13       -2
Impacted Files Coverage Δ
decepticonlp/transforms/perturbations.py 86.84% <100.00%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3c6dde...64987df. Read the comment docs.

@someshsingh22 someshsingh22 linked an issue May 12, 2020 that may be closed by this pull request
Typo Try Catch Exceptions #47
Closed
@someshsingh22 someshsingh22 mentioned this pull request May 12, 2020
Closed
rajaswa
rajaswa approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@rajaswa rajaswa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@rajaswa rajaswa merged commit ea1718f into SforAiDl:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajaswa rajaswa rajaswa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo Try Catch Exceptions
2 participants
@someshsingh22 @rajaswa