5.0.0: Rename utility functions breaking API change #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewRayCode
changed the title
AndrewRayCode
commented
Jul 28, 2024
| ]); | ||
| expect(ast.scopes[0].types.StructName.references).toHaveLength(16); | ||
| expect(ast.scopes[0].types.StructName_x.references).toHaveLength(16); |
There was a problem hiding this comment.
:) so much nicer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces breaking changs to the utility API functions
renameBindings,renameFunctions, andrenameTypesand changes their signatures to take the specific scope index, rather than the full scope.This also changes the signature of the
mangle()function to no longer be passed the AST node in question to be mangled.@shaderfrog/coreused this as a hack to set a property directly on AST nodes (.doNotDescope) to avoid other functions from touching it.It also exports new individual utility functions
renameBindingetc, and a helper debug function.These changes are largely in service of
@shaderfrog/coreto support better AST manipulation by allowing for the renameFunctions to modify scope indices. This is to keep the scopes in sync with the manipulated AST, which allows for more utility functions to work on scope, and avoid re-visiting an AST to find variables after an AST manipulation.