Support autoscroll when at lower or upper bound of the screen #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I9f2c213e1d8c16abee29de65eb19342091d6b280
|
Thank you so much! I will review & merge ASAP. |
|
Looking at the diff, looks like that all the previous code has been removed. Then I realized that you changed all the indentation from tabs to spaces, even for the code that you don't need to touch. I think it's common sense in every open source community that contributor should comply to the original coding style of the project. So if you have the time, could you change the indentation to tabs so that the code that doesn't need to be changed will not appear in the diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I9f2c213e1d8c16abee29de65eb19342091d6b280