Improve DestroyStackJob #1379
Merged
Improve DestroyStackJob #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
batch-delete-all
branch
from
2fa442c to
b817aae
Compare
DazWorrall
approved these changes
Nov 14, 2024
Do all the delete in batch of 1k all in the DB. Rather than fetch a list of IDs and generate a big `IN` delete query, we can just do it with a sub query and a LIMIT. On MySQL specifically we could directly do a `DELETE ... LIMIT`, but SQLite and PG don't support that syntax.
casperisfine
force-pushed
the
batch-delete-all
branch
from
b817aae to
22d05ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup: #1376, #1377
Do all the delete in batch of 1k all in the DB.
Rather than fetch a list of IDs and generate a big
INdelete query, we can just do it with a sub query and a LIMIT.On MySQL specifically directly do a
DELETE ... LIMIT, but SQLite and PG don't support that syntax so we use aDELETE FROM (SELECT id .. LIMIT)instead.