-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fit: pagination start end month #453
Open
MarceloRab
wants to merge
19
commits into
SimformSolutionsPvtLtd:master
Choose a base branch
from
MarceloRab:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Description
Added the feature to call back when reaching the first page and requesting a previous month and when reaching the last page and requesting a subsequent month.
Issue: #452
This was the best I could do. Adding a Gesturedetector only on the first and last month(pages). Because on the first and last page the PageView stops returning horizontal gesture listeners. This way I don't need to use NeverScrollableScrollPhysics to activate the gesture callback on the first and last page.
You can see from the commits that there has been an evolution. Bringing the final and initial drag return function only to the first and last pages. For there to be pagination, in addition to the gestures, the upper page change arrows need to remain on the first (left arrow) and last (right arrow). This work is up to the builder. In my app the arrows remain because I use [headerBuilder] manually.
This work took me a long time because I had to manipulate a PageView controller and GestureDetector. And this is my first fork with pull request.
I hope to contribute something.
The title of my PR starts with a Conventional Commit prefix (
fix:
,feat:
,docs:
etc).[ ]
I have followed the Contributor Guide when preparing my PR.[ ]
I have updated/added tests for ALL new/updated/fixed functionality.I have updated/added relevant documentation in
docs
and added dartdoc comments with///
.[ ]
I have updated/added relevant examples inexamples
ordocs
.[ ]
Yes, this PR is a breaking change.No, this PR is not a breaking change.