-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CODEOWNERS #1608
Make CODEOWNERS #1608
Conversation
Can I be made codeowner of _Arcadis? |
.github/CODEOWNERS
Outdated
**/*CVar*/*.cs @sleepyyapril | ||
|
||
# Discord | ||
/Content.*/Discord* @sleepyyapril |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/Content.*/Discord* @sleepyyapril | |
/Content.*/Discord* @sleepyyapril | |
Signed-off-by: sleepyyapril <[email protected]>
Signed-off-by: sleepyyapril <[email protected]>
Codeowners have write access |
Ah, makes sense. |
you can still add em, just won't do anything :godo: |
I thought it made it so if you made a PR changing that code, it requests the codeowner for review? |
It does if you have write access |
Triage and normal members I cannot request review from |
Doesn't say THAT anywhere in Github's documentation- are you sure? All the docs say in there is that you need write access to create the file |
Signed-off-by: Skubman <[email protected]>
maintainers get over here