Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CODEOWNERS #1608

Merged
merged 7 commits into from
Jan 20, 2025
Merged

Make CODEOWNERS #1608

merged 7 commits into from
Jan 20, 2025

Conversation

sleepyyapril
Copy link
Contributor

maintainers get over here

@github-actions github-actions bot added the Changes: YML Changes any yml files label Jan 20, 2025
@Erisfiregamer1
Copy link
Contributor

Can I be made codeowner of _Arcadis?

**/*CVar*/*.cs @sleepyyapril

# Discord
/Content.*/Discord* @sleepyyapril
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/Content.*/Discord* @sleepyyapril
/Content.*/Discord* @sleepyyapril

Signed-off-by: sleepyyapril <[email protected]>
Signed-off-by: sleepyyapril <[email protected]>
@sleepyyapril sleepyyapril deleted the codeowners branch January 20, 2025 01:18
@sleepyyapril sleepyyapril restored the codeowners branch January 20, 2025 01:18
@sleepyyapril sleepyyapril reopened this Jan 20, 2025
@sleepyyapril
Copy link
Contributor Author

Can I be made codeowner of _Arcadis?

Codeowners have write access

@Erisfiregamer1
Copy link
Contributor

Can I be made codeowner of _Arcadis?

Codeowners have write access

Ah, makes sense. We don't use CODEOWNERS on Arcadis, and I've never used it in my life.

@DEATHB4DEFEAT
Copy link
Member

you can still add em, just won't do anything :godo:

@Erisfiregamer1
Copy link
Contributor

you can still add em, just won't do anything :godo:

I thought it made it so if you made a PR changing that code, it requests the codeowner for review?

@Erisfiregamer1
Copy link
Contributor

Yep

{8C7D196B-DF5B-4B57-8FDB-A0AAF71504CD}

I'm like 99% sure that doesn't require write access on the codeowner's part.

@DEATHB4DEFEAT
Copy link
Member

you can still add em, just won't do anything :godo:

I thought it made it so if you made a PR changing that code, it requests the codeowner for review?

It does if you have write access

@DEATHB4DEFEAT
Copy link
Member

Triage and normal members I cannot request review from

@Erisfiregamer1
Copy link
Contributor

you can still add em, just won't do anything :godo:

I thought it made it so if you made a PR changing that code, it requests the codeowner for review?

It does if you have write access

Doesn't say THAT anywhere in Github's documentation- are you sure? All the docs say in there is that you need write access to create the file

Signed-off-by: Skubman <[email protected]>
@Erisfiregamer1
Copy link
Contributor

{02BB708D-EB7E-4A17-841C-33D776F0C78C}
Okay, you're right, I'm an idiot. Why doesn't it say that in the Github page on the subject??

@sleepyyapril sleepyyapril merged commit 0fa6a90 into Simple-Station:master Jan 20, 2025
11 checks passed
@sleepyyapril sleepyyapril deleted the codeowners branch January 20, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants