Fix/startup sh linefeed issue #1483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 's' in the end of keyword "clarification_question"
agent.clarification_question('What is the GDP of the United States?')
…#1417) * Add /app to PYTHONPATH * fix for issue Sinaptik-AI#1415 --------- Co-authored-by: Giuseppe Coco <[email protected]>
Co-authored-by: Giuseppe Coco <[email protected]>
Add documentation of how to use pandasai.json file
Sinaptik-AI#1432) * fix[output_format]: accept dataframe dict as output and secure sql query execution * fix: ruff errors
…aptik-AI#1429) * chore[Security]: restrict libs to allow specific functionalities * remove: extra lib handling * fix: ruff errors * fix: error message for bad import * fix: add io library in the blacklist
dosubot
bot
added
the
size:XXL
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to b809841 in 1 minute and 52 seconds
More details
- Looked at
1560lines of code in28files - Skipped
1files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. pandasai/connectors/sql.py:442
- Draft comment:
The error message "Malicious query is generated in code" is not clear. Consider rephrasing it to something like:
raise MaliciousQueryError("The generated SQL query is potentially malicious and has been blocked.")
- Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_EAXiGSgluR2UOlmv
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Enhances security by introducing restricted modules, updates library management, and fixes a linefeed issue in the startup script.
restricted_base64,restricted_datetime,restricted_json,restricted_matplotlib,restricted_numpy,restricted_pandas,restricted_seaborn) to prevent unauthorized access and execution of potentially harmful code._is_malicious_code()incode_cleaning.pyto check for restricted library access and private attribute usage.test_code_cleaning.pyto ensure restricted access and imports are handled correctly.WHITELISTED_LIBRARIESandRESTRICTED_LIBSinconstants.pyto reflect new security measures.get_environment()inoptional.pyto use restricted modules.custom-whitelisted-dependencies.mdxandlibrary.mdxto reflect changes in library management and security practices.startup.shinDockerfile.response_parser.pyto handle DataFrame conversion.This description was created by
for b809841. It will automatically update as commits are pushed.