Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some plot-related warnings in the tests #276

Closed
LTLA opened this issue Sep 13, 2024 · 2 comments
Closed

Fix some plot-related warnings in the tests #276

LTLA opened this issue Sep 13, 2024 · 2 comments

Comments

@LTLA
Copy link
Member

LTLA commented Sep 13, 2024

@dtm2451 can you have a look at some of the warnings in the plotting code? Not critical as the tests still pass, but you never know - I also did some major changes to the underlying code, so the warnings might be picking up something that the other tests didn't see.

(Check out the NEWS file for the scope of the changes. Results should largely be unaffected though there are a few minor changes due to differences in how we break ties between markers.)

@dtm2451
Copy link
Collaborator

dtm2451 commented Sep 16, 2024

The 4/5 from test-heatmap.R are our own totally expected, and tested, warnings where I should have cleaned this clutter from the tests previously... maybe they weren't reported in a past version, or maybe you newly added these warnings, but it's easy enough to make go away without hurting anything.
The last one from test-score-dist.R indicates I didn't update the plotting code around ggplot's removal of aes_string between v2->v3. Also easy to fix.

PR incoming

@LTLA
Copy link
Member Author

LTLA commented Sep 17, 2024

Closed by #277.

@LTLA LTLA closed this as completed Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants