Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean visualization test warnings #277

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Clean visualization test warnings #277

merged 2 commits into from
Sep 17, 2024

Conversation

dtm2451
Copy link
Collaborator

@dtm2451 dtm2451 commented Sep 16, 2024

Per #276:

  • cleans tests that needlessly report a warning was given
  • update ggplot code to use aes() directly rather than aes_string() per deprecation by ggplot
  • Adds a call utils::globalVariables(".data") within R/utils.R to avoid the undefined global variable Check Note. If preferred, the alternative to this would be using #' importFrom ggplot2 .data and moving ggplot2 from Suggests: to Imports:.

LTLA
LTLA approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@LTLA LTLA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean 👍

@LTLA LTLA merged commit 8b0b5ea into master Sep 17, 2024
1 check passed
@LTLA LTLA deleted the test-warn-fix branch September 17, 2024 05:01
@LTLA LTLA mentioned this pull request Sep 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LTLA LTLA LTLA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtm2451 @LTLA