Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.19.2 #125

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update to 1.19.2 #125

wants to merge 2 commits into from

Conversation

Catzy44
Copy link

@Catzy44 Catzy44 commented Nov 24, 2022

Description

ye ye, I saw the other pr, but it was too late, I was already done ;p
stb stopped working in 1.19.x because of removed dependency (apache commons-lang).
I was bored so i did some boilerplating and recreated all apache.lang methods used in plugin and put them into helpers package, inclucing these nasty Validator class.
everyting is working, using it on my public server.

Changes

redirected apache.commons.lang imports to classes inside helpers package
changed protection manager argument to instance of the plugin

Related Issues

(n/d)

Checklist

  • [y] I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • [y] I followed the existing code standards and didn't mess up the formatting.
  • [y] I did my best to add documentation to any public classes or methods I added.
  • [y] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values

@Catzy44 Catzy44 requested review from a team as code owners November 24, 2022 14:04
@HanPiRen
Copy link

any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants