Fix TypeError in CountryFilter.choices() #460
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no country is selected, self.used_parameters.get(self.field.name) will return None. This raises a TypeError when CountryFilter.choices() tries to check whether a specific country choice is currently selected.
Avoid this by checking that the parameter is not empty similarly to how Django's built-in admin.filters.RelatedFieldListFilter checks for this.
Fixes: 04662d1 ("Support Django 5.0")