Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update multicall with .env.bridge file #23

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Conversation

lesterli
Copy link
Member

@lesterli lesterli commented Oct 23, 2024

Summary

This PR updates the scripts under l2-bridge to fix an issue:

Updating .env.bridge file for OP Bridge UI...
/home/snapchain/op-chain-deployment/scripts/l2-bridge/l2-bridge-set-env.sh: line 37: NEXT_PUBLIC_L1_MULTICALL3_ADDRESS: unbound variable
make[1]: *** [Makefile:86: l2-bridge-start] Error 1

we removed NEXT_PUBLIC_L1_MULTICALL3_ADDRESS from the .env file, so:

  • l2-bridge-deploy-l1-multicall.sh: for the multicall was deployed case, it should update.env.bridge;
  • l2-bridge-set-env.sh: remove replacement line for NEXT_PUBLIC_L1_MULTICALL3_ADDRESS

Updates: Also, it will add two env vars for bridge ui.

Test Plan

To change the L1_RPC_URL with the Sepolia, run:

make l2-bridge-deploy-l1-multicall 

it should update NEXT_PUBLIC_L1_MULTICALL3_ADDRESS in .env.bridge with the value 0xcA11bde05977b3631167028862bE2a173976CA11

@lesterli lesterli changed the title fix: update multicall with wrong env file fix: update multicall with .env.bridge file Oct 23, 2024
@lesterli lesterli requested review from parketh and bap2pecs October 24, 2024 09:23
@lesterli lesterli merged commit ff639aa into main Oct 25, 2024
1 check passed
@lesterli lesterli deleted the fix/bridge-ui-env branch October 25, 2024 03:30
@bap2pecs
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants