fix(report): fix declaration a11y summary (#120)

* fix(report): fix declaration a11y summary * snaps
SocialGouv · Jan 13, 2022 · 42fe4ba · 42fe4ba
1 parent 0d18f02
commit 42fe4ba
Show file tree

Hide file tree

Showing 6 changed files with 2,262 additions and 2,274 deletions.
diff --git a/report/src/__snapshots__/generateUrlReport.test.js.snap b/report/src/__snapshots__/generateUrlReport.test.js.snap
@@ -44,7 +44,7 @@ Object {
     "totalCount": 42,
   },
   "declaration-a11y": Object {
-    "declaration": "Accessibilité : partiellement conforme",
+    "mention": "Accessibilité : partiellement conforme",
   },
   "dependabot": Object {
     "report": "dependabotalerts.json",

diff --git a/report/src/generateUrlReport.test.js b/report/src/generateUrlReport.test.js
@@ -61,7 +61,7 @@ describe("generateUrlReport", () => {
     mockJson("stats.json", { report: "stats.json" });
     mockJson("404.json", { broken: [1, 2, 3] });
     mockJson("declaration-a11y.json", {
-      declaration: "Accessibilité : partiellement conforme",
+      mention: "Accessibilité : partiellement conforme",
     });
 
     expect(

diff --git a/report/src/summary/declaration-a11y.js b/report/src/summary/declaration-a11y.js
@@ -13,11 +13,11 @@ const summary = (report) => {
       "declaration-a11y": undefined,
     };
   }
-  const foundGradeIndex = report.declaration
-    ? Object.values(grades).indexOf(report.declaration)
+  const foundGradeIndex = report.mention
+    ? Object.values(grades).indexOf(report.mention)
     : -1;
 
-  if (report.declaration === null) {
+  if (report.mention === null) {
     // not detected
     grade = "F";
   } else if (foundGradeIndex > -1) {

diff --git a/report/src/summary/declaration-a11y.test.js b/report/src/summary/declaration-a11y.test.js
@@ -2,31 +2,32 @@ const summary = require("./declaration-a11y");
 
 const tests = [
   {
-    declaration: undefined,
+    mention: undefined,
     expected: { "declaration-a11y": undefined },
   },
   {
-    declaration: null,
+    mention: null,
     expected: { "declaration-a11y": "F" },
   },
   {
-    declaration: "Accessibilité : totalement conforme",
+    mention: "Accessibilité : totalement conforme",
     expected: { "declaration-a11y": "A" },
   },
   {
-    declaration: "Accessibilité : partiellement conforme",
+    mention: "Accessibilité : partiellement conforme",
     expected: { "declaration-a11y": "B" },
   },
   {
-    declaration: "Accessibilité : non conforme",
+    mention: "Accessibilité : non conforme",
     expected: { "declaration-a11y": "C" },
   },
 ];
 
 describe("declaration-a11y", () => {
   tests.forEach((t) => {
-    test(`${t.declaration} should return ${JSON.stringify(t.expected)}`, () => {
-      expect(summary({ declaration: t.declaration })).toEqual(t.expected);
+    test(`${t.mention} should return ${JSON.stringify(t.expected)}`, () => {
+      //@ts-expect-error
+      expect(summary({ mention: t.mention })).toEqual(t.expected);
     });
   });
 });
diff --git a/report/src/summary/http.test.js b/report/src/summary/http.test.js
@@ -16,6 +16,7 @@ const tests = [
 describe("http", () => {
   tests.forEach((t) => {
     test(`${t.title} should return ${JSON.stringify(t.expected)}`, () => {
+      //@ts-expect-error
       expect(summary(t.report)).toEqual(t.expected);
     });
   });