Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home banners #16

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Home banners #16

merged 2 commits into from
Dec 9, 2024

Conversation

SofiaCantero24
Copy link
Owner

What does this do?

Home banners

simulator_screenshot_9ABB6D97-8B99-4488-9284-8CC59319C6C1

Notion Ticket

Figma view

Why did you do this?

Who/what does this impact?

How did you test this?

Copy link

@fernandatoledo fernandatoledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Importing media files directly for this purpose is not ideal for several reasons:

Accessibility: Images with embedded text often fail to meet accessibility standards, such as providing proper alternative text or being screen-reader friendly.

Localization: If the app supports multiple languages, each language would require its own set of images, which is not scalable or maintainable.

A more robust solution would be to create a reusable component for these banners. The component could take an image (or background color) as a prop, a variant to determine its layout (e.g., left or right alignment), and children for the text content. This structure allows you to manage styles, accessibility, and localization effectively.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary file

@SofiaCantero24 SofiaCantero24 merged commit ee4942b into main Dec 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants