feat: favorites view and API integration #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stukz
reviewed
Dec 13, 2024
src/app/(app)/favorites.tsx
Outdated
Comment on lines
45
to
48
| className={`mx-4 border ${ | ||
| isFirstItem ? 'rounded-t-lg' : '' | ||
| } ${isLastItem ? 'rounded-b-lg' : ''}`} | ||
| > |
There was a problem hiding this comment.
don't forget to use twMerge
Stukz
reviewed
Dec 13, 2024
src/app/(app)/product-list.tsx
Outdated
Comment on lines
76
to
78
| className={`mx-4 border ${isFirstItem ? 'rounded-t-lg' : ''} ${ | ||
| isLastItem ? 'rounded-b-lg' : '' | ||
| }`} |
Stukz
reviewed
Dec 13, 2024
| state === 'used' ? 'bg-restored' : 'bg-new' | ||
| }`} | ||
| > | ||
| <Text className={`text-xs font-semibold text-white`}> |
There was a problem hiding this comment.
Suggested change
| <Text className={`text-xs font-semibold text-white`}> | |
| <Text className="text-xs font-semibold text-white"> |
Stukz
reviewed
Dec 13, 2024
Comment on lines
19
to
21
| className={`mb-2 mt-1 w-12 items-center space-x-2 rounded-md px-2 py-1 ${ | ||
| state === 'used' ? 'bg-restored' : 'bg-new' | ||
| }`} |
Comment on lines
39
to
54
| const { mutate: addFavorite } = useAddFavorite({ | ||
| onSuccess: () => { | ||
| refetch(); | ||
| }, | ||
| onError: () => { | ||
| showErrorMessage('Something went wrong'); | ||
| }, | ||
| }); | ||
| const { mutate: removeFavorite } = useRemoveFavorite({ | ||
| onSuccess: () => { | ||
| refetch(); | ||
| }, | ||
| onError: () => { | ||
| showErrorMessage('Something went wrong'); | ||
| }, | ||
| }); |
There was a problem hiding this comment.
I feel this is too much responsability to the component to carry. Components should be mostly visual components and the logic should live in the parent
| }: TitleAndFavoriteProps) => { | ||
| const { mutate: addFavorite } = useAddFavorite({ | ||
| onSuccess: () => { | ||
| refetch(); |
There was a problem hiding this comment.
I recommend you to read about queries invalidations: https://tanstack.com/query/v3/docs/framework/react/guides/invalidations-from-mutations so you don't need to care about manually refetching.
Stukz
reviewed
Dec 13, 2024
| <Link | ||
| href={{ | ||
| pathname: detailsRoute, | ||
| params: { id: id }, |
There was a problem hiding this comment.
Suggested change
| params: { id: id }, | |
| params: { id }, |
Stukz
reviewed
Dec 13, 2024
| <Link | ||
| href={{ | ||
| pathname: detailsRoute, | ||
| params: { id: id }, |
There was a problem hiding this comment.
Suggested change
| params: { id: id }, | |
| params: { id }, |
| mutationKey: ['addFavorite'], | ||
| mutationFn: addFavorite, | ||
| onSuccess: (data, variables, context) => { | ||
| queryClient.invalidateQueries({ queryKey: ['products'] }); |
guillermomachado
approved these changes
Dec 16, 2024
Stukz
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Favorites screen and API
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-10.at.11.43.02.mp4
Notion Ticket
Figma view
Why did you do this?
Who/what does this impact?
How did you test this?