Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product detail Screen #9

Merged
merged 9 commits into from
Nov 11, 2024
Merged

Product detail Screen #9

merged 9 commits into from
Nov 11, 2024

Conversation

SofiaCantero24
Copy link
Owner

@SofiaCantero24 SofiaCantero24 commented Oct 25, 2024

What does this do?

Product Detail View

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-10-25.at.13.11.24.mp4

Notion Ticket

Figma view

Why did you do this?

Who/what does this impact?

How did you test this?

@@ -20,7 +20,9 @@ const FiltersButton = ({ products }: { products: Product[] }) => {
return;
}
return (
<View className="absolute -bottom-8 flex w-auto items-center justify-center self-center pb-20">
<View
className={`absolute bottom-24 flex w-auto items-center justify-center self-center pb-20`}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are not using the string interpolation

Suggested change
className={`absolute bottom-24 flex w-auto items-center justify-center self-center pb-20`}
className="absolute bottom-24 flex w-auto items-center justify-center self-center pb-20"

@@ -125,7 +127,7 @@ export default function ProductList() {
</TouchableOpacity>
<SearchBar setQuery={setQuery} query={query} />
<SearchResult query={query} clearQuery={clearQuery} />
<View className={`${query === '' ? 'pb-56' : 'pb-80'}`}>
<View className={`${query === '' ? 'pb-52' : 'pb-72'}`}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can do

Suggested change
<View className={`${query === '' ? 'pb-52' : 'pb-72'}`}>
<View className={query === '' ? 'pb-52' : 'pb-72'}>

@SofiaCantero24 SofiaCantero24 merged commit a89ef74 into main Nov 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants