Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLINTJS-61 Allow for wider margin of Typescript versions #4983

Merged
merged 2 commits into from
Dec 3, 2024
Merged

ESLINTJS-61 Allow for wider margin of Typescript versions #4983

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4f521d
ESLINTJS-61 Move Typescript as peerDependency
vdiez Dec 3, 2024
b87aaa2
ESLINTJS-61 Move Typescript as peerDependency
vdiez Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion generate-eslint-package-json.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ const eslintPluginDependencies = [
'typescript',
];

const fixedVersions = {
typescript: '^5',
};

const mainPackageJson = JSON.parse(
await fs.readFile(join(dirname(fileURLToPath(import.meta.url)), 'package.json'), 'utf8'),
);
Expand All @@ -47,7 +51,7 @@ for (const [name, value] of Object.entries(mainPackageJson.dependencies).concat(
Object.entries(mainPackageJson.devDependencies),
)) {
if (eslintPluginDependencies.includes(name)) {
dependencies[name] = value;
dependencies[name] = fixedVersions[name] ?? value;
const i = missingDependencies.indexOf(name);
missingDependencies.splice(i, 1);
}
Expand Down
Loading