Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS-478 Upgrade to ESLint 9 #5010

Merged
merged 9 commits into from
Jan 13, 2025
Merged

JS-478 Upgrade to ESLint 9 #5010

merged 9 commits into from
Jan 13, 2025

Conversation

vdiez
Copy link
Contributor

@vdiez vdiez commented Dec 10, 2024

https://eslint.org/docs/latest/use/migrate-to-9.0.0

topics to present

  1. new ruleTester objects
    • clarify which one to use when
  2. mandatory fields for test cases
    • mandatory: messages, suggestions (if provided)
    • the rest is optional
    • this has a big impact on the changes of this PR
  3. how to run tests in intelliJ / VScode
    • ruletester
    • cb framework
    • other
  4. schemas are strict:
    • for configurable rules, we need to provide the default values from the java check classes, otherwise, they might fail, as is done for S4275
  5. init-linter: there is a comment in LinterWrapper, should we also mention it to the squad?
  6. disallowAutomaticSingleRunInference parser option
    • see the comment in the code
  7. formatting rules were migrated to stylistic/eslint-plugin

TODO

ruling

  • go rule by rule
    • check if options changed and need to be added to the ruling config, as they seem to be mostly from decorated rules
  • fix or open tickets for rules that have worse behaviours like the exhaustive switch case one

@vdiez vdiez changed the title Upgrade to ESLint 9 JS-478 Upgrade to ESLint 9 Dec 10, 2024
Copy link
Contributor

@zglicz zglicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving a few comments. It's not helping much though.

packages/jsts/src/linter/wrapper.ts Outdated Show resolved Hide resolved
tools/foo.ts Outdated Show resolved Hide resolved
packages/jsts/tests/tools/testers/rule-tester.ts Outdated Show resolved Hide resolved
@vdiez vdiez force-pushed the migrate-eslint9 branch 2 times, most recently from 03e25ba to 82772f1 Compare January 10, 2025 16:46
@vdiez vdiez force-pushed the migrate-eslint9 branch 2 times, most recently from 7ff2f9b to 57cda49 Compare January 10, 2025 19:16
@vdiez vdiez requested a review from kebetsi January 10, 2025 19:40
@kebetsi kebetsi merged commit bda23d1 into master Jan 13, 2025
17 of 18 checks passed
@kebetsi kebetsi deleted the migrate-eslint9 branch January 13, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants