Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PullRequesteCreated.yml #4584

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Add PullRequesteCreated.yml #4584

merged 2 commits into from
Jan 9, 2025

Conversation

pavel-mikula-sonarsource
Copy link
Contributor

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@pavel-mikula-sonarsource pavel-mikula-sonarsource added dotnet rspec system Related to handling of rspecs (scripts, doc...) and removed dotnet labels Dec 19, 2024
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

marco-antognini-sonarsource
marco-antognini-sonarsource reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look at the implementation of the workflow -- looks good to me. Thanks for this!

I have one minor question on the pull request template.

.github/pull_request_template.md Show resolved Hide resolved
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Jan 9, 2025

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Jan 9, 2025

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@marco-antognini-sonarsource marco-antognini-sonarsource merged commit 8f2f6be into master Jan 9, 2025
9 checks passed
@marco-antognini-sonarsource marco-antognini-sonarsource deleted the Pavel/CreateWorkflow branch January 9, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-antognini-sonarsource marco-antognini-sonarsource marco-antognini-sonarsource left review comments

Assignees
No one assigned
Labels
rspec system Related to handling of rspecs (scripts, doc...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavel-mikula-sonarsource @marco-antognini-sonarsource