Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NET-943 Modify rule S1215: Add benchmark #4601

Merged
merged 3 commits into from
Jan 8, 2025
Merged

NET-943 Modify rule S1215: Add benchmark #4601

merged 3 commits into from
Jan 8, 2025

Conversation

martin-strecker-sonarsource
Copy link
Contributor

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

sebastien-marichal
sebastien-marichal requested changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@sebastien-marichal sebastien-marichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am under the impression that adding the benchmark bring more confusion than it helps to understand the gain from not calling GC.Collect.

rules/S1215/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S1215/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S1215/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S1215/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S1215/csharp/rule.adoc Outdated Show resolved Hide resolved
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Jan 8, 2025

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Jan 8, 2025

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

sebastien-marichal
sebastien-marichal approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@sebastien-marichal sebastien-marichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@martin-strecker-sonarsource martin-strecker-sonarsource merged commit 4be8383 into master Jan 8, 2025
10 of 11 checks passed
@martin-strecker-sonarsource martin-strecker-sonarsource deleted the Martin/Benchmark_S1215 branch January 8, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastien-marichal sebastien-marichal sebastien-marichal approved these changes

Assignees
No one assigned
Labels
dotnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martin-strecker-sonarsource @sebastien-marichal