Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONARJAVA-5262 Fix FP on S2187 in Cucumber tests with JUnit5. #4972

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

tomasz-tylenda-sonarsource
Copy link
Contributor

@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource commented Dec 24, 2024

Copy link

Quality Gate failed Quality Gate failed

Failed conditions
93.5% Coverage on New Code (required ≥ 95%)

See analysis details on SonarQube

Copy link

github-actions bot commented Jan 1, 2025

This PR is stale because it has been open 7 days with no activity. If there is no activity in the next 7 days it will be closed automatically

@github-actions github-actions bot added the stale label Jan 1, 2025
@tomasz-tylenda-sonarsource
Copy link
Contributor Author

This PR is not stale. It was on hold during holidays.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can complete the coverage by testing a class test annotated with type clashes

@IncompatibleAnnotations.IncludeEngines(42)
class ClassWithFakeIncludeEnginesAnnotationTest {// Noncompliant
}

class IncompatibleAnnotations {
  @interface IncludeEngines {
    int value();
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants