-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SONARJAVA-5262 Fix FP on S2187 in Cucumber tests with JUnit5. #4972
base: master
Are you sure you want to change the base?
Conversation
15d752b
to
32fc4b8
Compare
Quality Gate failedFailed conditions |
This PR is stale because it has been open 7 days with no activity. If there is no activity in the next 7 days it will be closed automatically |
This PR is not stale. It was on hold during holidays. |
...ecks-test-sources/default/src/test/java/checks/tests/NoTestInTestClassCheckCucumberTest.java
Outdated
Show resolved
Hide resolved
java-checks/src/main/java/org/sonar/java/checks/tests/NoTestInTestClassCheck.java
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can complete the coverage by testing a class test annotated with type clashes
@IncompatibleAnnotations.IncludeEngines(42)
class ClassWithFakeIncludeEnginesAnnotationTest {// Noncompliant
}
class IncompatibleAnnotations {
@interface IncludeEngines {
int value();
}
}
SONARJAVA-5262