Skip to content

Commit

Permalink
Update changelog and adapt messaging for SonarLint service
Browse files Browse the repository at this point in the history
  • Loading branch information
nquinquenel committed Mar 6, 2024
1 parent 15898e5 commit 4a18d25
Show file tree
Hide file tree
Showing 8 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ import org.sonarlint.intellij.common.util.SonarLintUtils
import org.sonarlint.intellij.core.BackendService
import org.sonarlint.intellij.util.runOnPooledThread

class RestartBackendAction : AbstractSonarAction("Restart SonarLint") {
class RestartBackendAction : AbstractSonarAction("Restart SonarLint Service") {

companion object {
const val SONARLINT_ERROR_MSG = "SonarLint encountered an issue and has stopped working"
const val SONARLINT_ERROR_MSG = "SonarLint service encountered an issue and has stopped working"
}

override fun actionPerformed(e: AnActionEvent) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import org.sonarlint.intellij.common.util.SonarLintUtils
import org.sonarlint.intellij.core.BackendService
import org.sonarlint.intellij.util.runOnPooledThread

class RestartBackendNotificationAction : NotificationAction("Restart SonarLint") {
class RestartBackendNotificationAction : NotificationAction("Restart SonarLint Service") {

override fun actionPerformed(e: AnActionEvent, notification: Notification) {
notification.expire()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ public void update(@Nullable VirtualFile file, @Nullable Collection<LiveIssue> i
var backendIsAlive = getService(BackendService.class).isAlive();
if (!backendIsAlive) {
statusText.setText(SONARLINT_ERROR_MSG);
statusText.appendLine("Restart SonarLint", SimpleTextAttributes.LINK_PLAIN_ATTRIBUTES,
statusText.appendLine("Restart SonarLint Service", SimpleTextAttributes.LINK_PLAIN_ATTRIBUTES,
ignore -> ActionUtil.invokeAction(restartSonarLintAction, this, CurrentFilePanel.SONARLINT_TOOLWINDOW_ID, null, null));
disableEmptyDisplay(false);
populateSubTree(tree, treeBuilder, Map.of());
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/sonarlint/intellij/ui/ReportPanel.java
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ private void handleEmptyView() {
var backendIsAlive = getService(BackendService.class).isAlive();
if (!backendIsAlive) {
statusText.setText(SONARLINT_ERROR_MSG);
statusText.appendLine("Restart SonarLint", SimpleTextAttributes.LINK_PLAIN_ATTRIBUTES,
statusText.appendLine("Restart SonarLint Service", SimpleTextAttributes.LINK_PLAIN_ATTRIBUTES,
ignore -> ActionUtil.invokeAction(restartSonarLintAction, this, CurrentFilePanel.SONARLINT_TOOLWINDOW_ID, null, null));
} else {
var sonarLintActions = SonarLintActions.getInstance();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ private void initPanel() {

sonarConfigureProject = new SonarConfigureProject();
notSupportedPanel = centeredLabel("Security Hotspots are currently not supported", "Configure Binding", sonarConfigureProject);
cardPanel.add(centeredLabel(SONARLINT_ERROR_MSG, "Restart SonarLint", new RestartBackendAction()), SONARLINT_ERROR_CARD_ID);
cardPanel.add(centeredLabel(SONARLINT_ERROR_MSG, "Restart SonarLint Service", new RestartBackendAction()), SONARLINT_ERROR_CARD_ID);
cardPanel.add(notSupportedPanel, NOT_SUPPORTED_CARD_ID);
cardPanel.add(centeredLabel("No Security Hotspots found for currently opened files in the latest analysis", null, null), NO_SECURITY_HOTSPOT_CARD_ID);
cardPanel.add(centeredLabel("No Security Hotspots shown due to the current filtering", null, null), NO_SECURITY_HOTSPOT_FILTERED_CARD_ID);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ class SonarLintDashboardPanel(private val editor: Editor) {
val gc = GridBag().nextLine()

val constrains = gc.next()
val noAccessLabel = HyperlinkLabel("Restart SonarLint").apply {
val noAccessLabel = HyperlinkLabel("Restart SonarLint Service").apply {
addHyperlinkListener(object : HyperlinkAdapter() {
override fun hyperlinkActivated(e: HyperlinkEvent) {
runOnPooledThread {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ class TaintVulnerabilitiesPanel(private val project: Project) : SimpleToolWindow
init {
val globalSettings = getGlobalSettings()
cards.add(
centeredLabel(SONARLINT_ERROR_MSG, "Restart SonarLint", RestartBackendAction()),
centeredLabel(SONARLINT_ERROR_MSG, "Restart SonarLint Service", RestartBackendAction()),
ERROR_CARD_ID
)
cards.add(centeredLabel("The project is not bound to SonarCloud/SonarQube", "Configure Binding", SonarConfigureProject()), NO_BINDING_CARD_ID)
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/META-INF/plugin.xml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@

<change-notes><![CDATA[
<ul>
<li>10.4 - Support of Java 21 and 2 new Java rules. 17 new accessibility rules for HTML. 9 new C++ rules. 2 new quick fixes for Python. 1 new JS/TS rule. Various UI fixes and improvements. Bug fixes, fewer FPs and improvements for many languages.</li>
<li>10.4 - SonarLint now runs in a separate process. Support of Java 21 and 2 new Java rules. 17 new accessibility rules for HTML. 2 new C++ rules. 2 new quick fixes for Python. 1 new JS/TS rule. Various UI fixes and improvements. Bug fixes, fewer FPs and improvements for many languages.</li>
<li>10.3 - Allow detection of custom secrets in connected mode starting from SonarQube 10.4. Set up a connection in one click starting from SonarQube 10.4 when using the Open in IDE feature. Fix memory leaks and UI freezes. Support Jakarta namespace. 9 new C++ MISRA 2023 rules. Remove support for Node.js 14 and deprecate support for Node.js 16 and Node.js 17. Support TypeScript 5.3. 5 new rules for JavaScript. 8 new rules for Kubernetes. Bug fixes, fewer FPs and improvements for many languages.</li>
<li>10.2.1 - Fix an error when using Rider or CLion in connected mode with SonarCloud.</li>
<li>10.2 - Support for Gradle Kotlin DSL and C# 12. 5 new Spring Boot rules. 1 new rule for Python. Bug fixes, fewer FPs and improvements for many languages.</li>
Expand Down

0 comments on commit 4a18d25

Please sign in to comment.